Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn if the origin paths are the same. #615

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

faximan
Copy link
Contributor

@faximan faximan commented Sep 12, 2022

The current conditions for printing build warnings are overly restrictive. While still not perfect, I believe this is a step in the right direction.

Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in other mail, the detection is deep.
This is fine for now, because it is certainly less noisy than before.

@aiuto aiuto merged commit 0f128a2 into bazelbuild:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants