New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_tar should not prefix tree artifacts with ./ #681

Merged

aiuto merged 1 commit into bazelbuild:main from clint-stripe:clint/pkg_tar-tree-strip_prefix

Mar 16, 2023

Contributor

clint-stripe commented Mar 15, 2023

Fixes #676

It was enlightening to note that build_zip doesn't have the same problem! build_zip's add_tree has a key special case that previously we didn't have in build_tar:
https://github.com/bazelbuild/rules_pkg/blob/main/pkg/private/zip/build_zip.py#L178-L194


          pkg_tar should not prefix tree artifacts with ./

f3e2302

clint-stripe requested review from aiuto and nacl as code owners

March 15, 2023 18:20

Collaborator

aiuto commented Mar 16, 2023

Thanks for an easy to review PR.

It fixes an issue that has been marked as a bug
It comes with a test

aiuto approved these changes

View reviewed changes

aiuto merged commit edd4d3d into bazelbuild:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet