Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %posttrans scriptlet to RPM package #799

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

k0walik
Copy link
Contributor

@k0walik k0walik commented Dec 21, 2023

RPM package specification defines %posttrans scriptlet, which can be particularly useful when upgrading a package. We should add it to the pkg_rpm build rule.

Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#ordering

@cgrindel
Copy link
Collaborator

@k0walik #797 just merged disabling the doc builds. I believe that those are causing all/most of the failures in your CI. Could you update your branch with the latest?

Copy link
Collaborator

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. A couple of comments:

  • I did not notice a test leveraging postrans_scriptlet_file. Could you add one?
  • Could you update your branch with the latest to address the doc_build failures?

@k0walik
Copy link
Contributor Author

k0walik commented Dec 21, 2023

  • I did not notice a test leveraging postrans_scriptlet_file. Could you add one?

Sure! I modified test/rpm/BUILD to test both xxx_scriptlet and xxx_scriptlet_file attributes - it looks like file variant was not tested at all.

  • Could you update your branch with the latest to address the doc_build failures?

Done

Copy link
Collaborator

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I won't merge it yet, so that @aiuto can take a look.

Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work.
Thanks for improving the testing

@aiuto aiuto merged commit 1e334d2 into bazelbuild:main Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants