Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal pip version to 23.3+ #1821

Closed
axbycc-mark opened this issue Mar 22, 2024 · 1 comment · Fixed by #1914
Closed

Update internal pip version to 23.3+ #1821

axbycc-mark opened this issue Mar 22, 2024 · 1 comment · Fixed by #1914
Labels
dependencies Pull requests that update a dependency file help wanted type: pip
Milestone

Comments

@axbycc-mark
Copy link

🚀 feature request

Update internal pip version to 23.3+
The current internal pip version is specified as 23.2

"https://files.pythonhosted.org/packages/50/c2/e06851e8cc28dcad7c155f4753da8833ac06a5c704c109313b8d5a62968a/pip-23.2.1-py3-none-any.whl",

Relevant Rules

pip.parse
compile_pip_requirements()

Description

The new http-v2 caching feature was introduced in pip 23.3. This feature separates out headers the body when caching responses from package servers. This fixes a performance issue that causes cached responses to be loaded and fully deserialized multiple times from disk during a single run of compile_pip_requirements / pip-compile. This is an issue for wheels that are GB in size.

Describe the solution you'd like

Update internal pip version to 23.3+ or maybe add a way for the user to specify the desired pip version when specifying pip.parse() or compile_pip_requirements().

Describe alternatives you've considered

Write a py_binary depending on the pip version I need and then run pip-compile inside that py_binary.

@aignas
Copy link
Collaborator

aignas commented Mar 24, 2024

I personally don't have time to look into this now, but will review PRs.

@aignas aignas added help wanted dependencies Pull requests that update a dependency file type: pip labels Mar 24, 2024
@aignas aignas added this to the v0.32.0 milestone Mar 29, 2024
@aignas aignas modified the milestones: v0.32.0, v0.33.0 May 13, 2024
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
Bumps:
* importlib_metadata: 6.8.0 -> 7.1.0
* more_itertools: 10.1.0 -> 10.2.0
* packaging: 23.1 -> 24.0
* pep517: 0.13.0 -> 0.13.1
* pip: 23.2.1 -> 24.0
* pyproject_hooks: 1.0.0 -> 1.1.0
* setuptools: 68.1.2 -> 70.0.0
* wheel: 0.41.2 -> 0.43.0
* zipp: 3.16.2 -> 3.18.2

Fixes #1821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted type: pip
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants