Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py_binary zip file on non-Windows is broken #1954

Closed
aignas opened this issue Jun 12, 2024 · 0 comments · Fixed by #1953
Closed

py_binary zip file on non-Windows is broken #1954

aignas opened this issue Jun 12, 2024 · 0 comments · Fixed by #1953

Comments

@aignas
Copy link
Collaborator

aignas commented Jun 12, 2024 •
edited
Loading

Introduced by #1929.
See bazelbuild/bazel#22718

Created #1953 to fix this and this ticket should be closed once we have tests for this behaviour.
@aignas aignas mentioned this issue Jun 12, 2024
Merged
aignas added a commit to aignas/rules_python that referenced this issue Jun 12, 2024
@aignas
fix(py_binary): drop the unused argument.
cd9f84d 
It seems that there is an extra argument that is there but I am not sure about
the reason, it is most likely a leftover. As part of this change we add an
analysis test for non-windows zip building. I could reproduce the failure and
now the newly added test passes.

Fixes bazelbuild#1954
github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
@aignas
fix(rules): drop the unused argument (#1953)
b07525c 
It seems that there is an extra argument that is there but I am not sure
about
the reason, it is most likely a leftover. As part of this change we add
an
analysis test for non-windows zip building. I could reproduce the
failure and
now the newly added test passes.

Fixes #1954
rickeylev pushed a commit to rickeylev/rules_python that referenced this issue Jun 13, 2024
@aignas @rickeylev
fix(rules): drop the unused argument (bazelbuild#1953)
026edb7 
It seems that there is an extra argument that is there but I am not sure
about
the reason, it is most likely a leftover. As part of this change we add
an
analysis test for non-windows zip building. I could reproduce the
failure and
now the newly added test passes.

Fixes bazelbuild#1954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rules): drop the unused argument bazelbuild/rules_python
1 participant
@aignas