bootstrap_impl=script doesn't handle RUNFILES_MANIFEST_FILE #2186
Comments
|
small correction: flag is |
|
The difficulty in reproducing this might related to a bazel bug: bazelbuild/bazel#7994 Basically, RUNFILES_MANIFEST_FILE isn't set when it should be under sandboxed execution. Testing this will be annoying. We can't modify I'm thinking it'll just be easier to have the shell test modify the env vars and call the binary again. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 5, 2024
…ES_MANIFEST_FILE set (#2177) The script-based bootstrap wasn't computing the correct runfiles directory when `RUNFILES_MANIFEST_FILE` was set. The path it computed stripped off the manifest file name, but didn't re-add the `.runfiles` suffix to point to the runfiles directory. To fix, just re-append the `.runfiles` suffix after it removes the manifest file name portion of the path. Reproducing this is a bit tricky and it's difficult to reproduce the necessary build flags in a test; all of the following must be met: * `--enable_runfiles=false`, but this cannot be set by transitions, only via command line * `--build_runfile_manifests=true` (this can be set in a transition, but see below) * Due to bazelbuild/bazel#7994, even if a manifest is created, the RUNFILES_MANIFEST_FILE env var won't be set _unless_ the test strategy is local (i.e. not sandboxed, which is the default). To work around those issues, the test just recreates the necessary envvar state and invokes the binary. The underlying files may not exist, but that's OK for the code paths were testing. Fixes #2186 --------- Co-authored-by: Richard Levasseur <rlevasseur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 bug report
Affected Rule
py_binary with
--boostrap_impl=scriptIs this a regression?
Yes, bootstrap=system_python doesn't have this problem
Originally reported by @scasagrande in #2177
Description
When bootstrap=script is used, it doesn't properly handle when
RUNFILES_MANIFEST_FILEis used to find the runfiles directory.Looking at the code, both code paths that look for
*.runfiles/MANIFESTand*.runfiles_manifestmight have the same problem.The fix is to reappend
.runfilesto the file name after stripping off the manifest location.🔬 Minimal Reproduction
To repro, these flags must be set:
--enable_runfiles=false --build_runfiles_manifests=true --spawn_strategy=localIt seems that the RUNFILES_MANIFEST_FILE envvar is only set for local executions when runfiles are disabled.
The text was updated successfully, but these errors were encountered: