Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support producing uncompressed wheels for development #2240

Closed
keith opened this issue Sep 20, 2024 · 3 comments · Fixed by #2260
Closed

Support producing uncompressed wheels for development #2240

keith opened this issue Sep 20, 2024 · 3 comments · Fixed by #2260

Comments

@keith
Copy link
Member

keith commented Sep 20, 2024

Currently py_wheel + wheelmaker uses standard zip compression when producing a wheel. When you're iterating on a wheel target, this can take a huge amount of time for large wheels with native binaries. In our case it takes ~3 minutes just to zip the dev wheel. It would be great if this compression knob was exposed somehow, in our case that time goes down to ~10 seconds if I just change this to zipfile.ZIP_STORED.
@rickeylev
Copy link
Contributor

I'd approve a PR adding an arg to py_wheel that plumbs through to affect the compression level.

@keith
Copy link
Member Author

keith commented Sep 20, 2024

Awesome! I can try to take a look at that next week

keith added a commit to keith/rules_python that referenced this issue Sep 27, 2024
@keith
Add attribute for disabling wheel compression
df887d6 
This is useful for development where, for large wheels, a significant
portion of the time can be spent compression native binaries

Fixes bazelbuild#2240
@keith keith mentioned this issue Sep 27, 2024
Merged
@keith
Copy link
Member Author

keith commented Sep 27, 2024

#2260

github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@keith
feat: add py_wheel.compress to control using compression (#2260)
b52f381 
This is useful for development where, for large wheels, a significant
portion of the time can be spent compression native binaries

Fixes #2240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add py_wheel.compress to control using compression keith/rules_python
2 participants
@keith @rickeylev