Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyright headers #916

Closed
chrislovecnm opened this issue Dec 6, 2022 · 4 comments · Fixed by #1030
Closed

Copyright headers #916

chrislovecnm opened this issue Dec 6, 2022 · 4 comments · Fixed by #1030
Assignees
@rickeylev

Comments

@chrislovecnm
Copy link
Collaborator

This is a housekeeping issue for the repo. I am noticing that we do not have copyright headers on the code files. See here: https://github.com/bazelbuild/bazel/blob/master/src/create_embedded_tools.py#L3 for an example of the header I a referring to. The go_fules repo uses the "addlicense" tool to update the headers in the code.

Is this something we should have in this repo as well?
@rickeylev rickeylev self-assigned this Jan 20, 2023
@rickeylev
Copy link
Contributor

I'm guessing the answer is probably "yes". I emailed our licensing people on the off chance the answer is "no"

@rickeylev
Copy link
Contributor

I heard back: the answer is yes, they should all have the copyright notice

@rickeylev rickeylev mentioned this issue Jan 30, 2023
Merged
rickeylev added a commit that referenced this issue Jan 30, 2023
@rickeylev
Add missing copyright headers (#1030)
018e355 
* Add missing copyright headers

Done by running:
`addlicense -v -c "The Bazel Authors. All rights reserved." .`

With a few changes reverted because they're for generated files or test goldens.

Fixes #916
@rickeylev
Copy link
Contributor

After talking with some lawyers, the couple generated files I skipped initially also need to have copyright headers added (just to the checked in file in our repo, the code-generator won't emit a copyright header). Gonna re-open this to address that.

@rickeylev rickeylev reopened this Feb 7, 2023
rickeylev added a commit to rickeylev/rules_python that referenced this issue Feb 24, 2023
@rickeylev
Add a script to add missing license headers
fbd1490 
Work towards bazelbuild#916
@rickeylev rickeylev mentioned this issue Feb 24, 2023
Merged
rickeylev added a commit that referenced this issue Feb 24, 2023
@rickeylev
Add a script to add missing license headers (#1094)
797c2d0 
Work towards #916
@chrislovecnm
Copy link
Collaborator Author

Closing. We fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickeylev rickeylev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing copyright headers
2 participants
@chrislovecnm @rickeylev