test(pip_parse): add integration tests for macros in requirements.bzl #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would depend on the value of .bazelrc and this change ensures that we are explicitly enable bzlmod via CLI args.
aignas
force-pushed
the
test/non-example-pip-parse-tests
branch
from
ac252f1
to
d8429df
Compare
rickeylev
pushed a commit
that referenced
this pull request
May 4, 2023
…d in .bazelrc (#1207) This correctly handles the integration tests and examples that are a part of the `rules_python` workspace and should not be included in the deleted packages list. This brings the changes made to the `.bazelrc` very close to what is in `main`, but I would like to update this later once #1155 and #1205 are merged. Fixes #919.
The PR bazelbuild#1190 fixed incompatible_generate_aliases breaking the `requirement` macro under `bzlmod`. This PR is a followup in establishing the test infrastructure using the classic `bazel` only for now. What is more, update the deleted packages with the fixed version of the script from bazelbuild#1207
…t/non-example-pip-parse-tests
aignas
force-pushed
the
test/non-example-pip-parse-tests
branch
from
d8429df
to
521486d
Compare
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1190 fixed incompatible_generate_aliases breaking the
requirementmacro underbzlmod. This PR is a followup inestablishing the test infrastructure using the classic
bazelonly fornow.
Work towards #958.