feat(bzlmod): Adding base_url attr to python.toolchain #1216
Conversation
The base_url attribute allows a user to override the URL that is passed into python_register_toolchains, via kwargs. This URL is then passed to python_repository which enables the download of a Python installation package from a custom URL. A user is now able to set a custom location that hosts the Python binaries.
| register_coverage_tool = toolchain_attr.configure_coverage_tool, | ||
| ignore_root_user_error = toolchain_attr.ignore_root_user_error, | ||
| ) | ||
| if toolchain_attr.base_url: |
There was a problem hiding this comment.
@rickeylev not sure if there is a cleaner way to do this. If we don't set the base_url when we call python.toolchain, we end up with an empty string passed in. Then python_register_toolchains passes in an empty value to python_repository. We may have a weird use case where an empty URL is allowed; if not, I can test for an empty URL in python_register_toolchains, which is fewer lines of code.
| The URL that is used to override rules_python DEFAULT_RELEASE_BASE_URL. This rule set downloads | ||
| the different Python binaries from this website. Override this URL if you want to have rules_python | ||
| download the hermetic versions of Python from a different website. | ||
| """, |
There was a problem hiding this comment.
Should we use the bazel downloader for this instead?
There was a problem hiding this comment.
Great question! I asked the folks on #1172 to get their opinion. I think folks are using base_url, so if we are not going to support it people will have to migrate to this as well.
There was a problem hiding this comment.
See #1172 (comment)
|
Folks are requesting feature parity |
|
Just to recap my post on the issue: An arg on the toolchain() tag class doesn't seem like the way to solve this. A separate tag class, probably only respected by the root module, to customize it would make more sense. Let's continue any design discussion on the issue and leave the PR for code review comments. |
|
Closing as we don't want to add an argument. |
The bazel_url attribute allows the user to set a custom location (URL) that hosts the Python binaries.
The base_url attribute allows users to override the URL passed into python_register_toolchains, via kwargs. This URL is then passed to python_repository, which enables the download of a Python installation package from a custom URL.
Closes #1172