Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Set toolchain target_setting directly instead of via inline ternary #1246

Merged
merged 1 commit into from
Jun 2, 2023

Commits on Jun 2, 2023

  1. cleanup: Set toolchain target_setting directly instead of via inline …

    …ternary
    
    The generated toolchain BUILD file is confusing to read because it
    relies on a ternary expression in the BUILD file to set the
    `target_settings` attribute. This makes debugging harder because,
    upon first look, all the toolchains appear to have the version
    constraint set. It's only upon closer inspection that you can see the
    1-character difference of "False" vs "True" embedded into the middle
    of a line amongst other similar looking lines.
    
    Also adds a bit of validation logic for the
    `set_python_version_constraint` argument because it's conceptually a
    boolean, but is passed as a string, so is prone to having an incorrect
    value passed.
    rickeylev committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5994046 View commit details
    Browse the repository at this point in the history