Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config_settings): allow matching minor version of python_version flag #1555

Merged
merged 9 commits into from
Jan 16, 2024
Merged

feat(config_settings): allow matching minor version of python_version flag #1555

merged 9 commits into from
Jan 16, 2024

Commits on Nov 13, 2023

  1. feat(config_settings): accept minor versions of Python in `python_ver… 

    …sion` flag

Currently user has to specify a full (x.y.z) version of Python when setting the
`python_version` flag. When they upgrade `rules_python` or change `MINOR_MAPPING`
in some other way, user has to update the flag's value to keep it in sync with
`MINOR_MAPPING`. This patch allows `python_version` flag to accept minor (x.y)
versions and resolves them to the corresponding full versions using `MINOR_MAPPING`.
    @dizzy57
    dizzy57 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7de7189 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge remote-tracking branch 'upstream/main' into minor_version_in_flag

    @rickeylev
    rickeylev committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    459f010 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. generate fewer settings to match across versions

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    768417c View commit details
    Browse the repository at this point in the history

  2. rename test file to be consistent, expand test cases

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    28d950f View commit details
    Browse the repository at this point in the history

  3. fix bug with repeated allowed values, add note about default value

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f76a5d5 View commit details
    Browse the repository at this point in the history

  4. update changelog to better reflect feature added

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    497123e View commit details
    Browse the repository at this point in the history

  5. fix lint errors

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b943bc8 View commit details
    Browse the repository at this point in the history

  6. dont accept minor version as flag value, add missing import in tests

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8bcdd00 View commit details
    Browse the repository at this point in the history

  7. alias config group for better ux; fix typo

    @rickeylev
    rickeylev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    997d37c View commit details
    Browse the repository at this point in the history