feat(whl_library): set target_compatible_with based on whl name #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pure starlark function to further parse the platform_tag from the wheel and set the correct attributes for the target generated by the whl_library rule. This should make errors much more easy to understand when users try to build a docker image using incompatible libraries. This is currently hidden under an experimental flag described in the changelog.
aignas
force-pushed
the
exp/pypi-library-target-compatible-with
branch
from
ce22c48
to
f068380
Compare
|
This is not the direction we want to follow in the future, because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pure starlark function to further parse the platform_tag from the
wheel and set the correct attributes for the target generated by the whl_library
rule. This should make errors much more easy to understand when users try to
build a docker image using incompatible libraries.
This is currently hidden under an experimental flag described in the changelog.
Related #735, #260