-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(whl_library): generate platform-specific dependency closures #1593
Merged
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 17ac24e - Browse repository at this point
Copy the full SHA 17ac24eView commit details -
internal: render.dict and render.select supports value_repr
This is to ensure that we can represent select of lists in a better way
Configuration menu - View commit details
-
Copy full SHA for 422f9df - Browse repository at this point
Copy the full SHA 422f9dfView commit details -
feat(pip_parse): generate target platform specific dependencies
Before this change, the dependency closures would be influenced by the host-python interpreter, this removes the influence by detecting the platforms against which the `Requires-Dist` wheel metadata is evaluated. This functionality can be enabled via `target_platforms` attribute to the `pip.parse` extension and is showcased in the `bzlmod` example. The same attribute is also supported on the legacy `pip_parse` repository rule. The detection works in the following way: - Check if the python wheel is platform specific or cross-platform (i.e., ends with `any.whl`), if it is then platform-specific dependencies are generated, which will go through a `select` statement. - If it is platform specific, then parse the platform_tag and evaluate the `Requires-Dist` markers assuming the target platform rather than the host platform. NOTE: The `whl` `METADATA` is now being parsed using the `packaging` Python package instead of `pkg_resources` from `setuptools`. Fixes bazelbuild#1591
Configuration menu - View commit details
-
Copy full SHA for 38b3dfe - Browse repository at this point
Copy the full SHA 38b3dfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1410f3 - Browse repository at this point
Copy the full SHA a1410f3View commit details
Commits on Dec 12, 2023
-
Apply suggestions from code review
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1f8bea2 - Browse repository at this point
Copy the full SHA 1f8bea2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69027d4 - Browse repository at this point
Copy the full SHA 69027d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9776120 - Browse repository at this point
Copy the full SHA 9776120View commit details -
Configuration menu - View commit details
-
Copy full SHA for b198336 - Browse repository at this point
Copy the full SHA b198336View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ef4159 - Browse repository at this point
Copy the full SHA 0ef4159View commit details -
Configuration menu - View commit details
-
Copy full SHA for e19a38a - Browse repository at this point
Copy the full SHA e19a38aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9200828 - Browse repository at this point
Copy the full SHA 9200828View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cb99c1 - Browse repository at this point
Copy the full SHA 6cb99c1View commit details
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77f504d - Browse repository at this point
Copy the full SHA 77f504dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 275a321 - Browse repository at this point
Copy the full SHA 275a321View commit details -
Configuration menu - View commit details
-
Copy full SHA for e913a0e - Browse repository at this point
Copy the full SHA e913a0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7014c3c - Browse repository at this point
Copy the full SHA 7014c3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b24956 - Browse repository at this point
Copy the full SHA 6b24956View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8481d0e - Browse repository at this point
Copy the full SHA 8481d0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for efd55e2 - Browse repository at this point
Copy the full SHA efd55e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40ccabf - Browse repository at this point
Copy the full SHA 40ccabfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.