Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py_runtime): Allow py_runtime to take an executable target as the interpreter #1621

Merged
merged 7 commits into from
Jan 8, 2024
Merged

feat(py_runtime): Allow py_runtime to take an executable target as the interpreter #1621

merged 7 commits into from
Jan 8, 2024

Commits on Dec 24, 2023

  1. Allow py_runtime to take an executable target as the interpreter

    @mishazharov
    mishazharov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    1541263 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @mishazharov
    mishazharov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    0b80df4 View commit details
    Browse the repository at this point in the history

  3. Address PR feedback

    @mishazharov
    mishazharov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    117608d View commit details
    Browse the repository at this point in the history

  4. Add unit test to verify basic behaviour

    @mishazharov
    mishazharov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    c60b21f View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. address rickeylev comments and general cleanup 

    * Wrap changelog text
* Make comment about allow_files more descriptive
* Improve doc about interpreter attribute behavior
* use helper_target()
    @rickeylev
    rickeylev committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6af9d0c View commit details
    Browse the repository at this point in the history

  2. Address further review comments 

    * add tests for binaries with multiple and single outputs
* switch to custom rule instead of using sh_binary
* fix bug where single-output binary rules wouldn't have runfiles
  merged in.
* puts the tests in a more alphabetical location
    @rickeylev
    rickeylev committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f80d2f3 View commit details
    Browse the repository at this point in the history

  3. sort dict items to fix lint failure

    @rickeylev
    rickeylev committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    15ab6df View commit details
    Browse the repository at this point in the history