-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runfiles): Added type hints to @rules_python//python/runfiles
#1654
Conversation
4bde898
to
5c18ef0
Compare
@rules_python//python/runfiles
@rules_python//python/runfiles
@rules_python//python/runfiles
@rules_python//python/runfiles
a4352e9
to
0d65082
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this looks good, but I'd like to wait for @rickeylev to have a look at this since this would constrain the runfiles
library to Python 3.7
and I don't know if this is something we want to do now.
EDIT: According to https://devguide.python.org/versions/, it is already EOL, so this concern may not be applicable and we can move forward to the better future with type annotations.
For what it’s worth, 3.7 was chosen because it’s EOL and I thought it would be a sufficiently low bar. |
Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
This change adds mypy types directly to the
rules_python.python.runfiles
library as well as regression testing to CI.