Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bzlmod): do not fail pip.parse with empty requirements.txt #1718

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jan 24, 2024

With this change we handle correctly the case where the requirements.txt
might be empty (e.g. during onboarding to rules_python). I have added
an integration test because this usecase seems important enough to be covered
to ensure that we have no regressions. It also creates a place to add more
pip.parse and pip_parse tests.

Closes #1623.

Copy link
Contributor

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small nits, otherwise lgtm

tests/integration/pip_parse/.bazelrc Outdated Show resolved Hide resolved
tests/integration/pip_parse/.gitignore Outdated Show resolved Hide resolved
@aignas aignas enabled auto-merge January 24, 2024 12:54
@aignas aignas added this pull request to the merge queue Jan 24, 2024
Merged via the queue into bazelbuild:main with commit 3730191 Jan 24, 2024
4 checks passed
@aignas aignas deleted the fix/no-packages branch January 25, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants