-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coverage) add coverage support for python 3.12 #1727
fix(coverage) add coverage support for python 3.12 #1727
Conversation
* chore(coverage): bump coverage to 7.4.1 * style: update comments on how to update coverage * fix(coverage): add cp312 support
I've not figured out how to use my local instance of rules_python to verify the changes are working as expected. |
The bzlmod example is failing when it is just trying to run bazel coverage and it seems that tho patch that we apply to the wheel may need revising. I think just doing bazel fetch for all of the coverage deps whilst in the rules_python workspace should be enough to test this. Maybe adding a skylib build_test to do that in tests/coverage/BUILD.bazel or similar would be good. |
If I am working on cd /examples/bzlmod
bazel coverage //...
# 8 fail locally |
* examples/bzlmod - bazel coverage //tests:version_3_10_takes_3_9_subprocess_test was always failing due to .coveragerc generated file not being unique * generating the locv report resulted in messages going to stdout/stderr that resulted in test failures. To fix this, we run with --quiet. If VERBOSE_COVERAGE is defined we will output to stderr.
update the patch file for coverage/__main__
Note that #1734 should be merged before this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* `bazel coverage ...` in the same fashion as `bazel test ...`
…t-add-coverage-for-3.12
* update the python_bootstrap_template to default /dev/null for stdout/stderr
* reverted presubmit 6.4.0 bazel ubuntu test case * added changelog information * remove setting stdin to /dev/null
…t-add-coverage-for-3.12
@aignas this PR is ready for merge as well. Thank you! |
Summary: