Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (WIP) Add pypi_install() rule #1728

Draft
wants to merge 114 commits into
base: main
Choose a base branch
from
Draft

feat: (WIP) Add pypi_install() rule #1728

wants to merge 114 commits into from

Commits on Jun 10, 2023

  1. Get started on new pypi_install repo rule 

    https://docs.google.com/document/d/12Yrc3Wyo7hZOroKdhgOgiduOCYor_UZyzpaQL9lY8sM/edit#
    @philsc
    philsc committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    10af2a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Actually generate an installation report

    @philsc
    philsc committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cf28cb6 View commit details
    Browse the repository at this point in the history

  2. skeleton pypi_install

    @philsc
    philsc committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5bb472f View commit details
    Browse the repository at this point in the history

  3. Generate crude intermediate format

    @philsc
    philsc committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    f5b53dd View commit details
    Browse the repository at this point in the history

  4. Generate http_file calls for all files

    @philsc
    philsc committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e1026c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Generate an intermediate representation

    @philsc
    philsc committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b6a7f0c View commit details
    Browse the repository at this point in the history

  2. Parse the report in user space

    @philsc
    philsc committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f9a9fa2 View commit details
    Browse the repository at this point in the history

  3. Combine the intermediate files

    @philsc
    philsc committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    327ba26 View commit details
    Browse the repository at this point in the history

  4. Start generating aliases 

    Still need to switch over to pointing at the py_library targets. Right
now I started writing them as pointing to the http_file targets.
    @philsc
    philsc committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    050d338 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Aliases are working 

        $ bazel query --output=build @pypi//...
    @philsc
    philsc committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    1f43e70 View commit details
    Browse the repository at this point in the history

  2. Wheel are now extracted

    @philsc
    philsc committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    97718eb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Add support for deps

    @philsc
    philsc committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    99e4924 View commit details
    Browse the repository at this point in the history

  2. regenerate intermediate file

    @philsc
    philsc committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    39e2a7c View commit details
    Browse the repository at this point in the history

  3. fix issues with version

    @philsc
    philsc committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    cd2325e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    317be76 View commit details
    Browse the repository at this point in the history

  2. Resolve merge conflict

    @philsc
    philsc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    9074c6c View commit details
    Browse the repository at this point in the history

  3. Import some wheels to get transitive deps with extras working.

    @philsc
    philsc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    8fcf5cc View commit details
    Browse the repository at this point in the history

  4. Make dependencies' deps work properly

    @philsc
    philsc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    4dfd766 View commit details
    Browse the repository at this point in the history

  5. Add a basic test

    @philsc
    philsc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    b0c9d33 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. fix test

    @philsc
    philsc committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    9438672 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    5639057 View commit details
    Browse the repository at this point in the history

  3. fix distribution for integration tests.

    @philsc
    philsc committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    93ac73c View commit details
    Browse the repository at this point in the history

  4. clean up a bit

    @philsc
    philsc committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    09e030f View commit details
    Browse the repository at this point in the history

  5. clean up more

    @philsc
    philsc committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    14150de View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. rename file

    @philsc
    philsc committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9c72809 View commit details
    Browse the repository at this point in the history

  2. clean up more

    @philsc
    philsc committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    98c0416 View commit details
    Browse the repository at this point in the history

  3. more cleanup

    @philsc
    philsc committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b346789 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Re-organize the logic a bit

    @philsc
    philsc committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    356c067 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    77a08d9 View commit details
    Browse the repository at this point in the history

  3. Start working on patching support

    @philsc
    philsc committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    614b434 View commit details
    Browse the repository at this point in the history

  4. add missing files

    @philsc
    philsc committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    34412f0 View commit details
    Browse the repository at this point in the history

  5. Start moving patch support into user space

    @philsc
    philsc committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    c58db28 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Actually pass patch args through

    @philsc
    philsc committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    34ff1c8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    fd3f40a View commit details
    Browse the repository at this point in the history

  3. Switch to BUILD.bazel

    @philsc
    philsc committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    00e83b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Fix deps

    @philsc
    philsc committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    831559e View commit details
    Browse the repository at this point in the history

  2. make patches actually work.

    @philsc
    philsc committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    35bbf8e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    b8536ba View commit details
    Browse the repository at this point in the history

  4. Make patches work with patch_dir

    @philsc
    philsc committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    d77b997 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. fix a couple of things.

    @philsc
    philsc committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    6d85b4f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    4dd5f28 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    32cc710 View commit details
    Browse the repository at this point in the history

  2. Make wrapped_py_wheel_library work for multiple configs

    @philsc
    philsc committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    36d0b85 View commit details
    Browse the repository at this point in the history

  3. maybe switch to transitive dep accumulation?

    @philsc
    philsc committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4b1c56d View commit details
    Browse the repository at this point in the history

  4. Fix circular dependencies maybe?

    @philsc
    philsc committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d40c04b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Introduce circular dependency

    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d2158f2 View commit details
    Browse the repository at this point in the history

  2. Give up on finding a package with a circular dependency for now. 

    apache-airflow and dvc[gs] require source packages.
    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f5e73de View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1890412 View commit details
    Browse the repository at this point in the history

  4. normalize name

    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    04776dd View commit details
    Browse the repository at this point in the history

  5. clean up

    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a75d69e View commit details
    Browse the repository at this point in the history

  6. add comment on circular dependencies.

    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8cb7e29 View commit details
    Browse the repository at this point in the history

  7. Rename pycross_wheel_library to py_wheel_library and make it work 

    This patch changes the name of the rule to reflect the fact that it's
not exactly the same as the one in rules_pycross.

I also took this opportunity to delete the superfluous
`namespace_pkgs.py` library (plus test) since we have a nearly
identical version already in the main repo.

I added a test to validate that the rule functions at a basic level.

References: bazelbuild#1360
    @philsc
    philsc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bdfd1d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bc3dcb0 View commit details
    Browse the repository at this point in the history

  2. Move test to //tests/pycross

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    dd2f722 View commit details
    Browse the repository at this point in the history

  3. fix one more call site

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e8386f1 View commit details
    Browse the repository at this point in the history

  4. remove one more superfluous reference

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a066006 View commit details
    Browse the repository at this point in the history

  5. Suppress buildifier warning

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ea9f5be View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'philsc/make-py-wheel-library-work' into… 

    … HEAD
    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b4e94d3 View commit details
    Browse the repository at this point in the history

  7. port changes to vendored version on main.

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e1775c3 View commit details
    Browse the repository at this point in the history

  8. run buildifier.

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    35c80ac View commit details
    Browse the repository at this point in the history

  9. switch to third_party version of pycross

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c451b9f View commit details
    Browse the repository at this point in the history

  10. add comment

    @philsc
    philsc committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    37ed85b View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. pycross: Add patching support to py_wheel_library 

    This patch adds a few arguments to `py_wheel_library` to simulate how
`http_archive` accepts patch-related arguments.

I also amended the existing test to validate the behaviour at a very
high level.

References: bazelbuild#1360
    @philsc
    philsc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dd84feb View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Compile GNU patch

    @philsc
    philsc committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bb46f2e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Make it work for Windows maybe?

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    91c0a30 View commit details
    Browse the repository at this point in the history

  2. add missing file

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7f4b344 View commit details
    Browse the repository at this point in the history

  3. clean up a bit

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c456eff View commit details
    Browse the repository at this point in the history

  4. fix buildifier warning

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    88d679e View commit details
    Browse the repository at this point in the history

  5. clean up deps

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    8fb9c6d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0a6b206 View commit details
    Browse the repository at this point in the history

  7. fix merge conflicts

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b8ef501 View commit details
    Browse the repository at this point in the history

  8. Clean up some more.

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    2b0cdaf View commit details
    Browse the repository at this point in the history

  9. buildifier

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7855521 View commit details
    Browse the repository at this point in the history

  10. black

    @philsc
    philsc committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    03d5b57 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6bd11b4 View commit details
    Browse the repository at this point in the history

  2. Go back to using host patch

    @philsc
    philsc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1d4f48a View commit details
    Browse the repository at this point in the history

  3. buildifier

    @philsc
    philsc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    13d59d3 View commit details
    Browse the repository at this point in the history

  4. black

    @philsc
    philsc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    50b4739 View commit details
    Browse the repository at this point in the history

  5. fail if user doesn't provide a patch tool.

    @philsc
    philsc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7619780 View commit details
    Browse the repository at this point in the history

  6. add missing file

    @philsc
    philsc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a4c5c69 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. fix typo

    @philsc
    philsc committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    322e295 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    651ffff View commit details
    Browse the repository at this point in the history

  3. import pypiserver

    @philsc
    philsc committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a099bda View commit details
    Browse the repository at this point in the history

  4. Run compile_pip_requirements against a pypiserver

    @philsc
    philsc committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b2b9fd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. minor edits

    @philsc
    philsc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    5b1e539 View commit details
    Browse the repository at this point in the history

  2. Split test cases to avoid unix_patcher.py

    @philsc
    philsc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    93d3edc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    7353010 View commit details
    Browse the repository at this point in the history

  4. fix arg type

    @philsc
    philsc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    05f47a6 View commit details
    Browse the repository at this point in the history

  5. add warning about non-hermeticity.

    @philsc
    philsc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    a4a2c71 View commit details
    Browse the repository at this point in the history

  6. buildifier

    @philsc
    philsc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    97c0378 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge remote-tracking branch 'philsc/add-patch-support-to-py-wheel-li… 

    …brary' into HEAD
    @philsc
    philsc committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    3997242 View commit details
    Browse the repository at this point in the history

  2. fix merge conflict

    @philsc
    philsc committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    acc5112 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'philsc/pypiserver-test' into HEAD

    @philsc
    philsc committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    915aadc View commit details
    Browse the repository at this point in the history

  4. start exposing some custom wheels

    @philsc
    philsc committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6926142 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Switch over to use pypiserver more.

    @philsc
    philsc committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d52e57b View commit details
    Browse the repository at this point in the history

  2. Fix a few more bugs

    @philsc
    philsc committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a8c12de View commit details
    Browse the repository at this point in the history

  3. Add genquery tests for circular dependencies

    @philsc
    philsc committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4ac70e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge remote-tracking branch 'upstream/main' into HEAD

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    8adf080 View commit details
    Browse the repository at this point in the history

  2. delete some stuff I'm not working on anymore

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    991e835 View commit details
    Browse the repository at this point in the history

  3. re-enable integration test

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    92aae04 View commit details
    Browse the repository at this point in the history

  4. fix up a few things.

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    bbc79ec View commit details
    Browse the repository at this point in the history

  5. Get //examples:pypi_install_bazel_self working

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    9dc8623 View commit details
    Browse the repository at this point in the history

  6. Tried and failed to adapt test based on bazel version.

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e29aba2 View commit details
    Browse the repository at this point in the history

  7. Generate an aarch64 intermediate file

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ad75959 View commit details
    Browse the repository at this point in the history

  8. add new package, update isn't working yet.

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7144829 View commit details
    Browse the repository at this point in the history

  9. Get multi-arch intermediate file update working.

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2bda97f View commit details
    Browse the repository at this point in the history

  10. get the basic example working.

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6c818b4 View commit details
    Browse the repository at this point in the history

  11. disable bzlmod for now

    @philsc
    philsc committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d41f491 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Add a better test for arch-dependent package

    @philsc
    philsc committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    33cdcb3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into HEAD

    @philsc
    philsc committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    45247be View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Try it out with multiple Python versions.

    @philsc
    philsc committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fd477fc View commit details
    Browse the repository at this point in the history

  2. Clean up naming.

    @philsc
    philsc committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    93f9df3 View commit details
    Browse the repository at this point in the history

  3. fix up tests

    @philsc
    philsc committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4bd6443 View commit details
    Browse the repository at this point in the history

  4. add version-specific package

    @philsc
    philsc committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1582943 View commit details
    Browse the repository at this point in the history