Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): generating lcov was causing issues #1734

Merged
merged 10 commits into from
Feb 5, 2024
Merged

fix(coverage): generating lcov was causing issues #1734

merged 10 commits into from
Feb 5, 2024

Commits on Jan 30, 2024

  1. fix(coverage): generating lcov was causing issues 

    * examples/bzlmod - bazel coverage //tests:version_3_10_takes_3_9_subprocess_test was always failing due to .coveragerc generated file not being unique
* generating the locv report resulted in messages going to stdout/stderr that resulted in test failures.  To fix this, we run with --quiet.  If VERBOSE_COVERAGE is defined we will output to stderr.
    @trentontrees
    trentontrees committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f3559d5 View commit details
    Browse the repository at this point in the history

  2. fix: use format style instead of f-string

    @trentontrees
    trentontrees committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    587061f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. fix: verify coverage works the same as test 

    * `bazel coverage ...` in the same fashion as `bazel test ...`
    @trentontrees
    trentontrees committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b996053 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'break-bazelci' into fix-coverage-lcov

    @trentontrees
    trentontrees committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0508403 View commit details
    Browse the repository at this point in the history

  3. fix: lcov stdout/err => /dev/null 

    * update the python_bootstrap_template to default /dev/null for stdout/stderr
    @trentontrees
    trentontrees committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0879d3f View commit details
    Browse the repository at this point in the history

  4. WIP: see if presubmit passes if we skip lcov

    @trentontrees
    trentontrees committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e27a64e View commit details
    Browse the repository at this point in the history

  5. during lcov generation, set stdin to /dev/null

    @trentontrees
    trentontrees committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    846df89 View commit details
    Browse the repository at this point in the history

  6. fix: presubmit.yml 

    * reverted presubmit 6.4.0 bazel ubuntu test case
* added changelog information
* remove setting stdin to /dev/null
    @trentontrees
    trentontrees committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d284eb5 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. add comment to give context to code

    @trentontrees
    trentontrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d86733d View commit details
    Browse the repository at this point in the history

  2. additional comment

    @trentontrees
    trentontrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    adfa957 View commit details
    Browse the repository at this point in the history