Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): correctly template error message in repository rules #1779

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

jesses-canva
Copy link
Contributor

@jesses-canva jesses-canva commented Feb 27, 2024

Fixes "Error in format: Missing argument 'path'" error and correctly templates the binary name and PATH.

(17:54:57) ERROR: /Users/jesses/work/canva/WORKSPACE:120:17: fetching whl_library rule //external:pypi_jsmin: Traceback (most recent call last):
	File "/private/var/tmp/_bazel_jesses/06c990151bb0d0bcaaf7ea85520191a3/external/rules_python/python/pip_install/pip_repository.bzl", line 783, column 59, in _whl_library_impl
		environment = _create_repository_execution_environment(rctx, python_interpreter)
	File "/private/var/tmp/_bazel_jesses/06c990151bb0d0bcaaf7ea85520191a3/external/rules_python/python/pip_install/pip_repository.bzl", line 257, column 47, in _create_repository_execution_environment
		cppflags.extend(_get_xcode_location_cflags(rctx))
	File "/private/var/tmp/_bazel_jesses/06c990151bb0d0bcaaf7ea85520191a3/external/rules_python/python/pip_install/pip_repository.bzl", line 121, column 46, in _get_xcode_location_cflags
		arguments = [repo_utils.which_checked(rctx, "xcode-select"), "--print-path"],
	File "/private/var/tmp/_bazel_jesses/06c990151bb0d0bcaaf7ea85520191a3/external/rules_python/python/private/repo_utils.bzl", line 164, column 39, in _which_checked
		"  PATH = {path}".format(rctx.os.environ.get("PATH"))))
Error in format: Missing argument 'path'

@jesses-canva jesses-canva marked this pull request as ready for review February 27, 2024 07:54
@aignas aignas changed the title fix: "Error in format: Missing argument 'path'" fix(internal): correctly template error message in repository rules Feb 27, 2024
@aignas aignas added this pull request to the merge queue Feb 27, 2024
Merged via the queue into bazelbuild:main with commit 627830e Feb 27, 2024
4 checks passed
@jesses-canva jesses-canva deleted the patch-1 branch February 28, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants