Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(internal_deps): Update 'maintained by' comments to be correct #1794

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

dougthor42
Copy link
Contributor

This fixes a minor error in the "maintained by" comments in
./MODULE.bazel and ./python/pip_install/repositories.bzl. The
comments now agree with what DEVELOPING.md says.

@dougthor42
Copy link
Contributor Author

dougthor42 commented Mar 11, 2024

Note: I'm not sure if fix(internal_deps) is the best type and scope for the PR. The PR has no impact on end users but does have a very minor impact on developers. Oh I didn't see the build type. Updated to build(internal_deps).

I found this while working on #1578.

@dougthor42 dougthor42 marked this pull request as ready for review March 11, 2024 19:00
@dougthor42 dougthor42 changed the title fix(internal_deps): Update 'maintained by' comments to be correct build(internal_deps): Update 'maintained by' comments to be correct Mar 11, 2024
@aignas aignas enabled auto-merge March 12, 2024 00:07
@aignas
Copy link
Collaborator

aignas commented Mar 12, 2024

@coeuvre, do you know what the build failure is about? It seems to fail with the RBE setup, but this PR hasn't changed anything, nor have we changed rules_python config regarding RBE in recent days.

@aignas aignas added this pull request to the merge queue Mar 12, 2024
@coeuvre
Copy link
Member

coeuvre commented Mar 12, 2024

@aignas Sorry, I recently made some changes to Bazel CI and accidentally broke RBE config for Bazel 6.4.0. It is fixed now.

Merged via the queue into bazelbuild:main with commit fdf9410 Mar 12, 2024
4 checks passed
@dougthor42 dougthor42 deleted the update-maintained-by-comments branch March 13, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants