feat: Add support for python-wheel data directory #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
BradHolmes
force-pushed
the
support-data-files-in-pywheel
branch
3 times, most recently
from
a4d20e5
to
9469321
Compare
aignas
reviewed
Mar 15, 2024
BradHolmes
force-pushed
the
support-data-files-in-pywheel
branch
2 times, most recently
from
5664bf2
to
b7c6da6
Compare
|
OK, I think this PR is ready. I updated the code, added a data check, added another test and an example. @rickeylev, I think this needs your approval. |
aignas
reviewed
Mar 21, 2024
BradHolmes
force-pushed
the
support-data-files-in-pywheel
branch
from
b7c6da6
to
3b5dc2c
Compare
aignas
reviewed
Mar 21, 2024
This feature addes attribute to the py_wheel rule and makes a related change to the wheelmaker tool. Fixes bazelbuild#1777
BradHolmes
force-pushed
the
support-data-files-in-pywheel
branch
from
3b5dc2c
to
2090a16
Compare
aignas
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1777
data_filesattribute topy_wheelrule.