Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal): add WORKSPACE.bzlmod to ensure dependency separation #1806

Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix(internal): add WORKSPACE.bzlmod to ensure dependency separation #1806

merged 4 commits into from
Mar 21, 2024

Commits on Mar 17, 2024

  1. fix(internal): add WORKSPACE.bzlmod to ensure dependency separation 

    Before this PR, WORKSPACE file would be also used when using
'rules_python' under bzlmod and when developing locally it would yield
to inconsistent behaviour between the examples and the main workspace.

This PR ensures that the `dev_pip` is used via `bzlmod`. Whilst there
may be a little bit of duplication from now on, it ensures that
non-bzlmod code paths do not leak into the bzlmod dev setup.
    @aignas
    aignas committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    7fee380 View commit details
    Browse the repository at this point in the history

  2. chore: move more things to MODULE.bazel

    @aignas
    aignas committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    d0aff56 View commit details
    Browse the repository at this point in the history

  3. chore: bzlmod gazelle example should not pin bazel version

    @aignas
    aignas committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    4541660 View commit details
    Browse the repository at this point in the history

  4. lint: buildifier fix

    @aignas
    aignas committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    effd851 View commit details
    Browse the repository at this point in the history