Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(whl_library): correctly parse wheel target platforms #1811

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix(whl_library): correctly parse wheel target platforms #1811

merged 1 commit into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. fix(whl_library): correctly parse wheel target platforms 

    The bazelbuild#1693 PR incorrectly assumed that the platform tag will be os-arch
specific if and only if the abi tag is of form cpxy. However, there are
many wheels that are not like this (e.g. watchdog, tornado, libclang).
This fixes the starlark code that is overriding the user platforms with
something that only the wheel supports by also taking into account the
ABI.

Fixes bazelbuild#1810.
    @aignas
    aignas committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0f30e02 View commit details
    Browse the repository at this point in the history