Loosen dash in proto path name check #1925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
reviewed
May 28, 2024
| @@ -58,7 +58,7 @@ def _py_proto_aspect_impl(target, ctx): | |||
|
|
|||
| # Check Proto file names | |||
| for proto in target[ProtoInfo].direct_sources: | |||
| if proto.is_source and "-" in proto.dirname: | |||
| if proto.is_source and "-" in proto.owner.package: | |||
There was a problem hiding this comment.
Could you please add a test to ensure that this actually works? Having the examples/bzlmod/proto be expanded would be great.
Whilst at it a note in CHANGELOG.md would be also great.
I think the reasoning in #1924 makes sense, so +1 for making the change.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Protobuf team is taking ownership of `py_proto_library` and the implementation was moved to protobuf repository. Remove py_proto_library from rules_python, to prevent divergent implementations. Make a redirect with a deprecation warning, so that this doesn't break any users. Expected side effect of this change is also that the protobuf version is sufficiently updated that there is no more use of legacy struct providers. Closes #1935 Closes #1924 Closes #1925 Closes #1703 Closes #1707 Closes #1597 Closes #1293 Closes #1080 Fixes #1438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924