revert(gazelle): revert #1895 as it is causing issues cross-building the plugin #1931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7fc7962.
#1895 has introduced a way to parse Python files without the need for
Python interpreter by leveraging the
tree-sitter
bindings for go.However, those bindings introduced a
C
dependency and as a result itwas breaking the cross-compilation of the
gazelle
plugin.The alternatives to revert are:
tree-sitter
, which would benefit users who don't needcross-compilation by speeding up
gazelle
signifficantly. As@dougthor42 showed, the
tree-sitter
implementation is 3 timesfaster, which is a great performance win.
care about in pure go.
there is no way to get the OSX sysroot on anything else than OSX os,
this is not trivial to do.
None of the alternatives look appealing due to increased maintenance or
effort, hence the only real alternative for the time being is to revert.
If the cross compilation of
CGO
programs becomes better, then we canlook at reverting this revert and using
tree-sitter
in the future.Fixes #1913