Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gazelle): Support "$python_root$" placeholder in the "gazelle:python_visibility" directive #1936

Merged
merged 5 commits into from
Jun 2, 2024
Merged

feat(gazelle): Support "$python_root$" placeholder in the "gazelle:python_visibility" directive #1936

merged 5 commits into from
Jun 2, 2024

Conversation

dougthor42
Copy link
Contributor

Add support for the $python_root$ placeholder in the # gazelle:python_visibility directive.

Fixes #1932.

@dougthor42 dougthor42 marked this pull request as ready for review June 1, 2024 23:15
@dougthor42 dougthor42 requested a review from f0rmiga as a code owner June 1, 2024 23:15
aignas
aignas reviewed Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to let people know in the changelog about the added support.

Thanks!

@dougthor42 dougthor42 changed the title Support "$python_root$" placeholder in the "gazelle:python_visibility" directive feat(gazelle): Support "$python_root$" placeholder in the "gazelle:python_visibility" directive Jun 2, 2024
@dougthor42
Copy link
Contributor Author

Thanks for the reminder! I also updated the PR title to conform.

@aignas aignas added this pull request to the merge queue Jun 2, 2024
Merged via the queue into bazelbuild:main with commit ae1e1a0 Jun 2, 2024
4 checks passed
@dougthor42 dougthor42 deleted the python-vis-python-root-gh1932 branch June 4, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@f0rmiga f0rmiga Awaiting requested review from f0rmiga f0rmiga is a code owner

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow $python_root$ in the # gazelle:python_visibility directive
2 participants
@dougthor42 @aignas