Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to protobuf 27.0 and remove py_proto_library (#1933) #1951

Closed
wants to merge 1 commit into from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jun 12, 2024

Reintroduce the changes in #1933, which got reverted in
commit 8b0eaed (#1948).

Reintroduce the changes in #1933, which got reverted in
commit 8b0eaed (#1948).
@aignas
Copy link
Collaborator Author

aignas commented Jun 12, 2024

Should wait before #1953 is merged.

@comius
Copy link
Contributor

comius commented Jun 13, 2024

My main motivation for this was #1956. There might be other solutions to it, and this PR could wait.

@aignas
Copy link
Collaborator Author

aignas commented Jun 17, 2024

Closing since #1957 got merged

@aignas aignas closed this Jun 17, 2024
@aignas aignas deleted the feat-breaking/reland-py-proto-library-removal branch October 17, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants