Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix a few typos in docs and function names #1978

Merged
merged 1 commit into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/private/common/attributes.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ in the resulting output or not. Valid values are:

* `inherit`: Inherit the value from the `--precompile_source_retention` flag.
* `keep_source`: Include the original Python source.
* `omit_source`: Don't include the orignal py source.
* `omit_source`: Don't include the original py source.
* `omit_if_generated_source`: Keep the original source if it's a regular source
file, but omit it if it's a generated file.
""",
Expand Down
2 changes: 1 addition & 1 deletion python/private/parse_requirements.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def parse_requirements(
contents = ctx.read(file)

# Parse the requirements file directly in starlark to get the information
# needed for the whl_libary declarations later.
# needed for the whl_library declarations later.
parse_result = parse(contents)

# Replicate a surprising behavior that WORKSPACE builds allowed:
Expand Down
2 changes: 1 addition & 1 deletion python/private/py_interpreter_program.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def _py_interpreter_program_impl(ctx):

py_interpreter_program = rule(
doc = """
Binary-like rule that doesn't require a toolchain becaues its part of
Binary-like rule that doesn't require a toolchain because its part of
implementing build tools for the toolchain. This rule expects the Python
interprter to be externally provided.

Expand Down
2 changes: 1 addition & 1 deletion python/private/py_toolchain_suite.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def py_toolchain_suite(*, prefix, user_repository_name, python_version, set_pyth
"""

# We have to use a String value here because bzlmod is passing in a
# string as we cannot have list of bools in build rule attribues.
# string as we cannot have list of bools in build rule attributes.
# This if statement does not appear to work unless it is in the
# toolchain file.
if set_python_version_constraint in ["True", "False"]:
Expand Down
4 changes: 2 additions & 2 deletions python/private/render_pkg_aliases.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ def get_filename_config_settings(
suffixes = target_platforms
else:
prefixes = ["{}_{}".format(py, abi)]
suffixes = _whl_config_setting_sufixes(
suffixes = _whl_config_setting_suffixes(
platform_tag = parsed.platform_tag,
glibc_versions = glibc_versions,
muslc_versions = muslc_versions,
Expand Down Expand Up @@ -578,7 +578,7 @@ def get_filename_config_settings(
else:
return [":is_{}".format(p) for p in prefixes], setting_supported_versions

def _whl_config_setting_sufixes(
def _whl_config_setting_suffixes(
platform_tag,
glibc_versions,
muslc_versions,
Expand Down
2 changes: 1 addition & 1 deletion python/private/repo_utils.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _execute_internal(
arguments,
environment = {},
**kwargs):
"""Execute a subprocess with debugging instrumention.
"""Execute a subprocess with debugging instrumentation.

Args:
rctx: repository_ctx object
Expand Down
2 changes: 1 addition & 1 deletion python/private/zip_main_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#
# NOTE: This file is a "stage 1" bootstrap, so it's responsible for locating the
# desired runtime and having it run the stage 2 bootstrap. This means it can't
# assume much about the current runtime and environment. e.g, the current
# assume much about the current runtime and environment. e.g., the current
# runtime may not be the correct one, the zip may not have been extract, the
# runfiles env vars may not be set, etc.
#
Expand Down