Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make first default output the executable again #2010

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: make first default output the executable again #2010

merged 2 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. fix: make first default output the executable again 

    This fixes a small change in behavior identified by some Google
regression tests. When precompiling was introduced, the target's
executable was no longer the first file in the default outputs depset.
While that behavior isn't a strong contract, it is the convention with
many other rules, and the existing historical behavior.

To fix, put the executable as the first value in the default outputs
list. Also adds a test for this behavior.
    @rickeylev
    rickeylev committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b0bda97 View commit details
    Browse the repository at this point in the history

  2. fix ci: behavior is bazel 7+

    @rickeylev
    rickeylev committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    40149b2 View commit details
    Browse the repository at this point in the history