Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): Remove the extra indirection and
bzlmod
folder #2022(chore): Remove the extra indirection and
bzlmod
folder #2022Changes from all commits
6570535
e57055f
5cb882b
604d525
98bff09
9063fca
ba819e8
68f9b10
f6c17a2
1f397bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should have a separate
python/private/toolchain
orpython/private/interpreter
directory, which could have all of thepython
extension related things. Thepythons_hub.bzl
could be in that folder as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. Probably an independent PR? It's a bigger change to discuss. Because we could also leave the python stuff where it is and move everything else out, which then makes it less urgent to change the Python toolchain or language rules.
This file was deleted.