tests: add integration test for build_python_zip #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There we go. CI is happy now. PTAL |
aignas
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more comprehensive regression test for verifying
--build_python_zipisactually working (#1840)
This also creates a small framework to make it easier to write integration tests that
need to customize the environment bazel runs in and check the output of bazel itself.
I figure this will be helpful for writing simple verification tests for repository/bzlmod
phase logic (i.e. set the debug env vars and grep the output). While we should avoid heavy
usage of these bazel-in-bazel tests, a bit of grepping logs would go a long way for covering
edge cases that examples don't cover.