-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pypi): fix the whl selection algorithm after #2069 #2078
Conversation
Would this show up as the "Fetching repo bla bla ..." step taking a long time? When I was working on the docs yesterday, there were a couple pypi deps (markup safe sounds familiar) that seemed to be taking a long time to become available. I chalked it up slow downloads or because I was modifying the pypi blz code, but maybe it was building it from source in the repo phase. |
Correct, it was building |
It seems that a few things broke in recent commits:
MODULE.bazel.lock
file and it seems that it is easy tomiss when the components in the PyPI extension stop integrating well
together. This happened during the switch to
{abi}_{os}_{plat}
targetplatform passing within the code.
to add the
rule_name
.repo_utils.getenv
was always gettingPATH
env var on bazel6.x
.This PR fixes both cases and updates docs to serve as a better reminder. By
fixing the
select_whls
code and we can just rely on target platform triples(ABI, OS, CPU). This gets one step closer to maybe supporting optional
python_version
which would address #1708. Whilst at it we are also addingdifferent status messages for building the wheel from
sdist
vs justextracting or downloading the wheel.
Tests:
MODULE.bazel.lock
files in ourrules_python
extension before refactor(pypi): split out more utils and start passing 'abi_os_arch' around #2069 and after this PR and there are nodifferences except in the
experimental_target_platforms
attribute inwhl_library
. Before this PR you would see that we do not select any wheelsfor e.g.
MarkupSafe
and we are always building fromsdist
.Work towards #260.