Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle relative paths properly in _absolute_url #2153

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

WillMorrison
Copy link
Contributor

This updates the simpleapi parser to handle indexes where wheel and sdist may be an index_url relative path. It also organises the conditionals with fewer negations so they're easier to read

Fixes: #2150

Copy link

google-cla bot commented Aug 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This updates the simpleapi parser to handle indexes where wheel and sdist may be an index_url relative path.
It also organizes the conditionals with fewer negations so they're easier to read
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aignas aignas added this pull request to the merge queue Aug 24, 2024
Merged via the queue into bazelbuild:main with commit e331afe Aug 24, 2024
4 checks passed
@WillMorrison WillMorrison deleted the absolute_url branch August 25, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bzlmod) Index responses containing relative paths for wheels causes bazel downloader to fail.
2 participants