Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly check the arg count in precompiler.py #2165

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Aug 29, 2024

This is supposed to check that all argument counts are equal, but due to an incorrect inversion of the conditional, it was checking that any pair of argument counts is equal

This is supposed to check that all argument counts are equal, but due to an incorrect inversion of the conditional, it was checking that *any* pair of argument counts is equal
@oprypin oprypin requested a review from rickeylev August 29, 2024 08:39
@oprypin oprypin requested a review from aignas as a code owner August 29, 2024 08:39
@rickeylev rickeylev added this pull request to the merge queue Aug 29, 2024
@rickeylev
Copy link
Contributor

Thanks! I forgot that comparison chaining implicitly uses and between the pieces, but a negative comparison doesn't "expand" (I forget the logic term, commute? transitive?) like that, it needs to use or to be logically equivalent.

Merged via the queue into main with commit 31e4771 Aug 29, 2024
7 checks passed
@oprypin oprypin deleted the fix-precompiler-eq branch August 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants