wip: set the python_version_flag in the pythons_hub on bzlmod #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
This is a different take on #2205. Summary: - Remove version constraints from the `//python/config_settings:python_version`. - Remove `is_python_config_setting` macro and use a different implementation to retain the same functionality. This in general will improve the situation on how the toolchains are registered and hopefully is a step towards resolving issues for #2081.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick draft to discuss the structure where:
--python_versionis defined within@rules_pythonwhenbzlmodis disabled.--python_versionis defined within@pythons_hubwhenbzlmodis enabled.The later allows us to ensure that we can have the right value enforcement when
the user can add extra toolchains at will.
BREAKING: For backwards compatibility we still have the alias for the config
flag present in
//python/config_settings:python_version, but we don't haveany
is_python_3.xany more in there and they are moved to the@python_hubsrepository, users have to use those symbols instead.