Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make precompile tests pass when other toolchains are defined #2213

Merged
merged 1 commit into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. tests: make precompile tests pass when other toolchains are defined

    This makes the precompile_tests pass when the environment defines custom
    toolchains that don't match what rules_python defines in its dev
    environment. This keeps the tests independent of whatever the user's
    environment is.
    
    Along the way:
    * Also force `--allow_unresolved_symlinks=true` in the tests. This flag
      isn't enabled in certain environments, but is implicitly relied upon
      by the `current_interpreter_executable` rule when a platform runtime
      is used (as they are in the tests).
    * Move the Python testing toolchains to support/py_toolchains, to match
      where the cc testing toolchains were moved.
    rickeylev committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    90e7f4f View commit details
    Browse the repository at this point in the history