fix: Prefix bootstrap file to prevent pytest reentrance #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Mostly LGTM, just some small doc changes needed. I suggested an edit for one. Can you please add some text to CHANGELOG.md, too? e.g. under the fixed header, add something like:
* (rules) Prevent pytest from trying run the generated stage2
bootstrap .py file when using {obj}`--bootstrap_impl=script`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest will, by default, discover tests in files named
test_*.py. The existing behaviour of the bootstrap setup is to create a file named e.g.test_foo_stage2_bootstrap.pyfor a target namedtest_foo. This causes pytest to reenter, leading to a crash.To fix, prepend the generated stage2 file with an underscore so that pytest doesn't match it.