refactor: add builders to make creating PyInfo/depset/runfiles easier #2251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add some builders "classes" to make constructing PyInfo, depsets, and runfiles
a bit cleaner. Previously, building such objects required creating multiple local
variables for each arg/attribute of the object (e.g. list_of_files and list_of_depsets
for building a depset). Keeping track of all the variables was verbose and tedious.
To make it easier, encapsulate that bookkeeping in some objects. Accumulating parts is
now much easier: builders have an
add()
method that looks at the input and stores itin the appropriate place.
This builders will be exposed to users in an upcoming PR to make building and merging
PyInfo objects easier.
Work towards #1647