Fix regression in parsing requirements due to invalid entry points config. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
changed the title
UebelAndre
force-pushed
the
entrypoint
branch
2 times, most recently
from
35d7be5
to
a461c3c
Compare
|
@alexeagle Requesting you as the reviewer since you were the reviewer for #523 and will likely have the most context. |
bshashank
reviewed
Sep 17, 2021
UebelAndre
force-pushed
the
entrypoint
branch
from
a461c3c
to
181d2f3
Compare
alexeagle
approved these changes
Sep 17, 2021
| # https://docs.python.org/3.7/library/configparser.html#configparser.ConfigParser | ||
| # https://docs.python.org/3.7/library/configparser.html#configparser.Error | ||
| except configparser.Error: | ||
| pass |
There was a problem hiding this comment.
I wish we could do something more in this case. We could warn, but developers are warnings-blind (for good reasons) plus this would be printed during repository rule execution which will scroll off the screen before you actually try to use the generated entry point scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Dependencies which have a potentially invalid
entry_points.txtfile will currently cause parsing dependencies to fail, rendering your code unbuildable.Issue Number: N/A
What is the new behavior?
The
entry_pointsfunctionality should at this point never result in a fatal error when parsing dependencies. This allows dependencies to continue to be generated as they did before in the event thatentry_points.txtis malformed.Does this PR introduce a breaking change?
Other information