Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined name in purelib.py #604

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fix undefined name in purelib.py #604

merged 2 commits into from
Jan 18, 2022

Conversation

hrfuller
Copy link
Contributor

Follow up for #581 fixing undefined name.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hrfuller
Fix undefined name in purelib.py
0bac44b 
Follow up for #581 fixing undefined name.
@hrfuller hrfuller merged commit d7ce569 into main Jan 18, 2022
@hrfuller hrfuller deleted the hrfuller-patch-2 branch January 18, 2022 07:29
thundergolfer
thundergolfer reviewed Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundergolfer thundergolfer thundergolfer left review comments

@f0rmiga f0rmiga f0rmiga approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrfuller @f0rmiga @thundergolfer