Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose defs.bzl form resolved_interpreter_os_alias as a target #659

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Mar 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

This broke my stardoc targets when I went to plug in the new toolchains to pip_parse since I have all that in macros that are called by other repositories.

Issue Number: N/A

What is the new behavior?

This allows users to access {name}_resolved_interpreter//:defs.bzl as a target so stardoc can successfully generate documentation.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review March 15, 2022 23:57
@alexeagle
Copy link
Collaborator

Yup looks right, same reasoning as

# Ensure the `requirements.bzl` source can be accessed by stardoc, since users load() from it
exports_files(["requirements.bzl"])

@alexeagle alexeagle merged commit 6c20dcd into bazelbuild:main Mar 16, 2022
@UebelAndre UebelAndre deleted the stardoc branch March 16, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants