fix: fail if the user is root #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rmiga
requested review from
hrfuller
and removed request for
brandjon and
lberki
hrfuller
approved these changes
Jul 12, 2022
| if uid == 0: | ||
| fail("The current user is root, please run as non-root when using the hermetic Python interpreter. See https://github.com/bazelbuild/rules_python/pull/713.") | ||
| else: | ||
| fail("The current user has CAP_DAC_OVERRIDE set, please drop this capability when using the hermetic Python interpreter. See https://github.com/bazelbuild/rules_python/pull/713.") |
There was a problem hiding this comment.
Perhaps a comment with https://man7.org/linux/man-pages/man7/capabilities.7.html for developers would be helpful.
Also, add a new attribute for the brave to ignore the check. Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
groodt
force-pushed
the
f0rmiga/check-root-user
branch
from
672303f
to
545fea5
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen folks excluding the
.pycfiles due to cache misses. See:This PR adds a check under Linux and macOS that fails if running as root. For those who want to still ignore it, I added a new attribute.