feat(gazelle_python_manifest): provide a target with the given name #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Agreed, and it's documented on https://bazel.build/rules/bzl-style#macros:
A macro should take a name argument and define a target with that name. That target becomes that macro's main target.
alexeagle
approved these changes
Aug 10, 2022
mattem
deleted the
feat/gazelle_python_manifest_has_a_default_target_that_makes_query_better
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a somewhat useful target as the "default" target for the macro, that is, the target that is the actual name of the macro.
Having this is incredibly useful when attempting to do static analysis of BUILD files to determine targets, but where those targets are macros and don't expand to a target with the given name it causes issues with any further bazel processing of that target (as it doesn't exist!).
While there are workarounds, it seems sane and good practice to simply provide a target with that name.