Add .bzl files explicitly to toolchain tests to detect .bzl file changes #815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Python toolchain tests did not include the rules_python distribution directly in the tests, and so bazel could cache a toolchain test result even if the toolchain bzl files changed. This could mean that toolchain bugs could be introduced but CI would pass because the tests were cached and did not run.
Issue Number: #806
What is the new behavior?
Add the rules_python distribution to the test files/runfiles so that bazel can detect changes in the bzl files and invalidate the
test cache. Therefore CI should correctly catch test failures.
Does this PR introduce a breaking change?
Other information