Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify timeout for gazelle manifest test #817

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

garymm
Copy link
Contributor

@garymm garymm commented Aug 30, 2022

Fixes #802

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

I think this doesn't apply here, but LMK if there's something you want me to do.

  • Docs have been added / updated (for bug fixes / features)

Ditto

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Manifest test timeout is not set. Whatever it defaults to is too long, at least for my manifests, and bazel complains.

Issue Number: #802

What is the new behavior?

manifest test timeout is set to "short"

Does this PR introduce a breaking change?

In theory if someone's manifest test takes too long to run, this could break them.
In practice this seems very unlikely.
LMK if you want me to make this an option instead.

  • Yes
  • No

Other information

@f0rmiga f0rmiga merged commit ad0b8f8 into bazelbuild:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow specifying test timeout in gazelle_python_manifest
2 participants