-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gazelle panics when "# gazelle:ignore" doesn't have a value #915
fix: gazelle panics when "# gazelle:ignore" doesn't have a value #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is invalid. The # gazelle:ignore on a Python file requires a value. If you want to replace the panic with a more specific error, then you will have to change asAnnotation to also return an error.
Thank you for review. Fixed to return the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding the test. Just check the suggestions before merging.
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If
# gazelle:ignore
line exists gazelle panics.commit hash 6434e34 (added new test line)
//gazelle:gazelle_test failes
What is the new behavior?
Ignores erorr. This is similar behavior if module name is invalid.
Does this PR introduce a breaking change?
Other information