fix: windows *.lib interface in python_headers
#976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
lummax
force-pushed
the
add-interface-file-in-python-headers
branch
from
4552278
to
8dd7edd
Compare
f0rmiga
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Could you update the vendored files as per https://buildkite.com/bazel/rules-python-python/builds/3953#0185864a-040b-45b6-8b06-6bb8f054b316, please?
…ibrary A user might use `python_headers` to build an extension module that does not itself pull in the python shared library. On Windows, this needs to expose the `*.lib` interface file to compile correctly.
lummax
force-pushed
the
add-interface-file-in-python-headers
branch
from
8dd7edd
to
a7a15ce
Compare
|
I am not sure how that failure relates to this PR. But I have rebased on
|
f0rmiga
changed the title
*.lib interface file to the python_headers l…*.lib interface in python_headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user might use
python_headersto build an extension module that does not itself pull in the python shared library. On Windows, this needs to expose the*.libinterface file to compile correctly.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently a user on Windows can not compile a native extension module and build against
python_headers.Issue Number: N/A
What is the new behavior?
It is fixed.
Does this PR introduce a breaking change?