Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream wrappers for cargo, rustc, cargo-clippy #2703

Merged
merged 12 commits into from
Jun 25, 2024
Merged

upstream wrappers for cargo, rustc, cargo-clippy #2703

merged 12 commits into from
Jun 25, 2024

Conversation

kolloch
Copy link
Contributor

@kolloch kolloch commented Jun 18, 2024

@google-cla Google CLA
Copy link

google-cla bot commented Jun 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kolloch
Copy link
Contributor Author

kolloch commented Jun 19, 2024

@illicitonion also offered to have a look

illicitonion
illicitonion reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question around tests :)

examples/bazel_env/all_crate_deps_test.sh Outdated Show resolved Hide resolved
@kolloch kolloch force-pushed the feature/upstream_wrapper branch 4 times, most recently from bc74ed8 to c99007b Compare June 20, 2024 18:18
@kolloch
Copy link
Contributor Author

kolloch commented Jun 20, 2024

@illicitonion as described above, I am now prepending the bin directory to the PATH in the wrapper so that cargo can find cargo-clippy, rustc and rustfmt -- even if they are not setup with bazel_env but only called with bazel_run.

Also added some tests as requested that test this.

@kolloch
Copy link
Contributor Author

kolloch commented Jun 24, 2024

@illicitonion I rebased it on #2700 since it had conflicts. (Thanks BTW)

illicitonion
illicitonion approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much!

@illicitonion illicitonion added this pull request to the merge queue Jun 25, 2024
Merged via the queue into bazelbuild:main with commit c1ab10a Jun 25, 2024
3 checks passed
rrbutani referenced this pull request in bazel-contrib/toolchains_llvm Jul 9, 2024
@renovate
chore(deps): update dependency rules_rust to v0.47.1 (#354)
421aa20 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rules_rust](https://togithub.com/bazelbuild/rules_rust) |
http_archive | minor | `0.46.0` -> `0.47.1` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_rust (rules_rust)</summary>

###
[`v0.47.1`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.47.1)

[Compare
Source](https://togithub.com/bazelbuild/rules_rust/compare/0.46.0...0.47.1)

### 0.47.1

#### Bzlmod

```python
bazel_dep(name = "rules_rust", version = "0.47.1")
```

#### WORKSPACE

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-35cwdTOaqqu4y+aXgIUU2C2PAKMz4+uyJ7/UMIGCmFs=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.47.1/rules_rust-v0.47.1.tar.gz"],
)
```

Additional documentation can be found at:
https://bazelbuild.github.io/rules_rust/#setup

#### What's Changed

- Remote vendor doesn't require srcs present by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_rust/pull/2688](https://togithub.com/bazelbuild/rules_rust/pull/2688)
- Add flag to refer to a `sh_toolchain` for process wrapper bootstrap
shebangs by [@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2694](https://togithub.com/bazelbuild/rules_rust/pull/2694)
- Added Rust 1.79.0 by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2695](https://togithub.com/bazelbuild/rules_rust/pull/2695)
- `crate_universe`: Make module extension restarts less expensive. by
[@&#8203;criemen](https://togithub.com/criemen) in
[https://github.com/bazelbuild/rules_rust/pull/2691](https://togithub.com/bazelbuild/rules_rust/pull/2691)
- Add example of using JNI to call into Rust by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_rust/pull/2690](https://togithub.com/bazelbuild/rules_rust/pull/2690)
- Apply extra_rustc_flags list to all toolchains by
[@&#8203;nmattia](https://togithub.com/nmattia) in
[https://github.com/bazelbuild/rules_rust/pull/2693](https://togithub.com/bazelbuild/rules_rust/pull/2693)
- rust-analyzer: Factor aliases into the project by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_rust/pull/2709](https://togithub.com/bazelbuild/rules_rust/pull/2709)
- crate_universe docs: Split bzlmod from workspace by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_rust/pull/2700](https://togithub.com/bazelbuild/rules_rust/pull/2700)
- Updated external dependencies docs by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2711](https://togithub.com/bazelbuild/rules_rust/pull/2711)
- Update wasm-bindgen to 0.2.92 by
[@&#8203;alexkirsz](https://togithub.com/alexkirsz) in
[https://github.com/bazelbuild/rules_rust/pull/2714](https://togithub.com/bazelbuild/rules_rust/pull/2714)
- upstream wrappers for cargo, rustc, cargo-clippy by
[@&#8203;kolloch](https://togithub.com/kolloch) in
[https://github.com/bazelbuild/rules_rust/pull/2703](https://togithub.com/bazelbuild/rules_rust/pull/2703)
- Clean up downloads that go through the API instead of the CDN by
[@&#8203;ograff](https://togithub.com/ograff) in
[https://github.com/bazelbuild/rules_rust/pull/2718](https://togithub.com/bazelbuild/rules_rust/pull/2718)
- Updated rust-analyzer to use repo vs generated files as crate roots by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2717](https://togithub.com/bazelbuild/rules_rust/pull/2717)
- crate-universe allows workspaces with MODULE.bazel only by
[@&#8203;matt-duch](https://togithub.com/matt-duch) in
[https://github.com/bazelbuild/rules_rust/pull/2720](https://togithub.com/bazelbuild/rules_rust/pull/2720)
- Release 0.47.0 by
[@&#8203;UebelAndre](https://togithub.com/UebelAndre) in
[https://github.com/bazelbuild/rules_rust/pull/2725](https://togithub.com/bazelbuild/rules_rust/pull/2725)
- Update bindgen.bzl to use toolchain system include directories as well
by [@&#8203;hlopko](https://togithub.com/hlopko) in
[https://github.com/bazelbuild/rules_rust/pull/2727](https://togithub.com/bazelbuild/rules_rust/pull/2727)
- Use newer macos runners by
[@&#8203;ograff](https://togithub.com/ograff) in
[https://github.com/bazelbuild/rules_rust/pull/2732](https://togithub.com/bazelbuild/rules_rust/pull/2732)

#### New Contributors

- [@&#8203;nmattia](https://togithub.com/nmattia) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2693](https://togithub.com/bazelbuild/rules_rust/pull/2693)
- [@&#8203;kolloch](https://togithub.com/kolloch) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2703](https://togithub.com/bazelbuild/rules_rust/pull/2703)
- [@&#8203;matt-duch](https://togithub.com/matt-duch) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2720](https://togithub.com/bazelbuild/rules_rust/pull/2720)

**Full Changelog**:
bazelbuild/rules_rust@0.46.0...0.47.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
alexeagle added a commit to aspect-build/rules_lint that referenced this pull request Sep 17, 2024
@alexeagle
chore: point to non-deprecated rustfmt
d40a19e 
See bazelbuild/rules_rust#2703
@alexeagle alexeagle mentioned this pull request Sep 17, 2024
Merged
alexeagle added a commit to aspect-build/rules_lint that referenced this pull request Sep 17, 2024
@alexeagle
chore: point to non-deprecated rustfmt (#392)
c32ebda 
* chore: point to non-deprecated rustfmt

See bazelbuild/rules_rust#2703

* chore: upgrade rules_rust

* Update Bar.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre left review comments

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolloch @illicitonion @UebelAndre